chore: update tools.json #3512
chore: update tools.json #3512
Conversation
asyncapi-bot
requested review from
derberg,
akshatnema,
magicmatatjahu,
anshgoyalevil,
Mayaleeeee and
asyncapi-bot-eve
as code owners
WalkthroughThe pull request introduces modifications to two configuration files: Changes
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
✅ Deploy Preview for asyncapi-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3512 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 21 21
Lines 664 664
=======================================
Hits 575 575
Misses 89 89 ☔ View full report in Codecov by Sentry. |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-3512--asyncapi-website.netlify.app/ |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🔭 Outside diff range comments (1)
config/tools-automated.json (1)
Line range hint
721-736: Inconsistent language specification in templatesThe Java Template specifies "javascript" as its language, which appears to be incorrect given it's a Java template.
Apply this fix:
"filters": { "language": [ - "javascript" + "java" ],Also applies to: 739-756
🧹 Nitpick comments (3)
config/all-tags.json (1)
1-1: Improve JSON file readabilityThe file is currently formatted as a single line, which makes it difficult to read and maintain. Consider formatting the JSON with proper indentation.
-{"languages":[{"name":"Go/Golang"...}]} +{ + "languages": [ + { + "name": "Go/Golang", + ... + } + ] +}config/tools-automated.json (2)
516-531: Update AsyncAPI Validation descriptionThe description could be more detailed to explain what types of validation are supported (schema validation, message validation, etc.).
Line range hint
799-814: Consider updating HTML Template technology tagsSince the template uses AsyncAPI React component, consider adding "React JS" to the technology list for better discoverability.
"technology": [ - "HTML" + "HTML", + "React JS" ],
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
config/all-tags.json(1 hunks)config/tools-automated.json(12 hunks)
🔇 Additional comments (3)
config/all-tags.json (1)
1-1: Consistent color scheme update looks good
The standardization of colors (bg-[#61d0f2] and border-[#40ccf7]) across multiple technologies improves visual consistency. The addition of the "amqp" technology aligns well with the tools updates in tools-automated.json.
config/tools-automated.json (2)
52-70: New nestjs-asyncapi tool entry looks good
The new tool entry is well-structured with appropriate categorization and clear description.
143-166: Verify ZenWave SDK categorization
The tool appears in multiple categories (Code Generators, DSL, CLIs). While this might be intentional as it serves multiple purposes, please verify if all categories are still applicable after recent changes.
✅ Verification successful
Based on the search results, I can see that ZenWave SDK appears consistently in the tools list with the following categories:
- code-generator
- dsl
- mocking-and-testing
- cli
The tool is properly categorized as it serves multiple purposes:
- Code Generator: It generates code for Spring Cloud Streams from AsyncAPI specifications
- DSL: It provides Domain-Specific Language support with JHipster JDL integration
- Mocking and Testing: It includes testing capabilities for Event-Driven Microservices
- CLI: It offers command-line interface functionality
The categorization is accurate and consistent with the tool's features and capabilities as shown in its description: "DDD and API-First for Event-Driven Microservices" and its technology stack including Maven, Spring Cloud Streams, and JHipster JDL.
All categories are correctly applied and verified
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for all occurrences of ZenWave SDK to ensure consistent categorization
rg -A 20 "ZenWave SDK" --json | jq -r '.data.lines.text' | grep -E "title|categories"
Length of output: 51953
| "title": "SIO-AsyncAPI", | ||
| "description": "This is code-first approach to generate AsyncAPI specification from Socket.IO server.", | ||
| "links": { | ||
| "websiteUrl": "https://www.npmjs.com/package/zod-sockets", | ||
| "repoUrl": "https://github.com/RobinTail/zod-sockets" | ||
| "websiteUrl": "https://github.com/daler-rahimov/sio-asyncapi", | ||
| "docsUrl": "https://github.com/daler-rahimov/sio-asyncapi", | ||
| "repoUrl": "https://github.com/daler-rahimov/sio-asyncapi" | ||
| }, | ||
| "filters": { | ||
| "language": "TypeScript", | ||
| "language": "Python", | ||
| "technology": [ | ||
| "Node.js", | ||
| "TypeScript" | ||
| "Socket.IO", | ||
| "Flask" | ||
| ], | ||
| "categories": [ | ||
| "code-first", | ||
| "dsl", | ||
| "framework" | ||
| "api" | ||
| ], | ||
| "hasCommercial": false, | ||
| "isAsyncAPIOwner": false | ||
| } |
There was a problem hiding this comment.
Duplicate tool entry detected
The "SIO-AsyncAPI" tool appears twice in the file - once in the "APIs" section and once in "Code-first tools". Consider keeping it in the most appropriate category and removing the duplicate.
Automated changes by create-pull-request GitHub action
Summary by CodeRabbit
New Features
nestjs-asyncapiand templates likeNode.js Multiprotocol TemplateandJava Template.Bug Fixes
Zod SocketstoSIO-AsyncAPI.Documentation